potiuk commented on code in PR #33685:
URL: https://github.com/apache/airflow/pull/33685#discussion_r1306046598
##########
airflow/providers/openlineage/provider.yaml:
##########
@@ -59,6 +59,13 @@ config:
example: ~
default: "False"
version_added: ~
+ disabled_for_operators:
+ description: |
+ Comma separated string of Airflow Operator names to disable
+ type: boolean
+ example: "BashOperator,PythonOperatorOperator"
Review Comment:
I **think** we should change the check and check fully qualifed name
instead. The task_type uses __class__.name - and while it is good for display,
it's not good to determine if we should disable/enable something. This is a
generic function that could by also used to disable custom operators, so what
happens if someone has
* my_package_a.MyOperator
* my_package_b.MyOperator
and we want to only disable the one from my_package_a ?
With `task_type` it's not possible. Maybe a bit "artifdficial" but i think
we should make it possible and non-amibguous.
I am not even sure if we don't have in our codebase two operators named in
the same way (would be worth checking)
I think this parameter will be rarely used and there is little benefit of
having it "easier" to add. I think those who will be adding the exclusion will
value the "explicitness" and `non-ambiguity" over "brevity".
We already have quite a few configurations where we enter fully qualified
names of classes we refer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
