SBurwash opened a new pull request, #33782:
URL: https://github.com/apache/airflow/pull/33782
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Good day!
I'd like to make a small modification to the **EcsTaskOperator**'s default
behavior to ensure that the task does not time out after 10 minutes.
Historically, the **ECSTaskOperator** would by default set its waiters'
`max_attemps` limit to `sys.maxsize`. However, this was changed to a default of
10 minutes `(waiter_max_attemps * waiter_delay) = 100 * 6 = 600s = 10 minutes`
(see
[PR](https://github.com/apache/airflow/commit/92cab74b280e9e7162120506c46fe275fbe0b577)
where behavior changed).
To amend this, we:
- Changed the default value for the `waiter_max_attempts` for the
**ECSTaskOperator** from 100 to `sys.maxsize`
- Removed legacy line which did not affect operator behavior
- Edited tests to reflect changes
Thanks to @vincbeck for the input on the changes.
<!-- Please keep an empty line above the dashes. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
