eladkal commented on code in PR #33696:
URL: https://github.com/apache/airflow/pull/33696#discussion_r1307291479


##########
airflow/providers/microsoft/azure/operators/container_instances.py:
##########
@@ -126,11 +126,11 @@ def __init__(
         self,
         *,
         ci_conn_id: str,
-        registry_conn_id: str | None,
         resource_group: str,
         name: str,
         image: str,
         region: str,
+        registry_conn_id: str | None = None,

Review Comment:
   mmm we are to considered this as breaking change since this changes the 
order of parameters and will break code of users that passes positional 
arguments



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to