uranusjr commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1309723602
########## airflow/jobs/scheduler_job_runner.py: ########## @@ -86,6 +86,10 @@ DR = DagRun DM = DagModel +# type alias for task concurrency map, +# (dag_id, run_id, task_group_id) -> concurrency limitation and set of running map indexes +TaskGroupConcurrencyMap = Dict[Tuple[str, str, str], Tuple[int, Set[int]]] Review Comment: Is the concurrency limit (first int in the value) used anywhere? I tried but could not find one. It seems the code can be simplified a bit if we don’t pass that value. ########## airflow/jobs/scheduler_job_runner.py: ########## @@ -86,6 +86,10 @@ DR = DagRun DM = DagModel +# type alias for task concurrency map, +# (dag_id, run_id, task_group_id) -> concurrency limitation and set of running map indexes +TaskGroupConcurrencyMap = Dict[Tuple[str, str, str], Tuple[int, Set[int]]] Review Comment: Is the concurrency limit (first int in the value) used anywhere? I tried but could not find one. It seems the code can be simplified a bit if we don’t pass that value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
