uranusjr commented on PR #33914: URL: https://github.com/apache/airflow/pull/33914#issuecomment-1700477867
Including logs in the exception message was added in #14761 (confusingly in a pull request that otherwise has nothing to do with the Docker operator) here: https://github.com/apache/airflow/commit/566127308f283e2eff29e8a7fbfb01f17a1cd18a#diff-5ec82e1fcaaa38e04471f56b64ec319f67b146d3a18d8bdb69c2f973ea3dd585 But the behaviour was not explicitly tested until much later, in another seemingly unrelated pull request #21175. So I think there’s really no particular reason to maintain the behaviour if it is problematic. It is probably still a good idea to keep the log somewhere (for example, raise a custom exception that has a `logs` attribute that holds the log message). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
