vincbeck commented on code in PR #33901:
URL: https://github.com/apache/airflow/pull/33901#discussion_r1312007402


##########
airflow/api_connexion/endpoints/role_and_permission_endpoint.py:
##########
@@ -40,14 +40,14 @@
 
 if TYPE_CHECKING:
     from airflow.api_connexion.types import APIResponse, UpdateMask
-    from airflow.www.security import AirflowSecurityManager
+    from airflow.www.security_manager import AirflowSecurityManagerV2

Review Comment:
   Since on the long term we will deprecate `AirflowSecurityManager` in favor 
of `AirflowSecurityManagerV2` I am wondering if `AirflowSecurityManagerV2` is a 
good name since this name will stay. Should we keep the name 
`AirflowSecurityManager`? It can confusing but we can assume this is only 
temporary? Or should we come up with another name? 
`SimplifiedAirflowSecurityManager`? I dont like it either xD. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to