potiuk commented on PR #34004:
URL: https://github.com/apache/airflow/pull/34004#issuecomment-1704191390

   One small thing also to add: 
https://github.com/apache/airflow/blob/0d93cc5cab8cef56faf3be1705ec6784e2d8a74a/docs/build_docs.py#L92
  - contains instructions displayed after docs are build and we should promote 
new arguments there, not ``--package-filter``.
   
   There is also a follow-up after that one, but it should be a separate PR. We 
should adapt the current CI/selective checks to use the list of short package 
ids rather than `--package-filter` . Our 'selective checks` produce the list of 
packages to build in the form of `--package-filter` but - with this change it 
should not be needed any more - we could just use remove 
`docs-filter-list-as-string` output completely and pass the 
`affected-providers-list-as-string` to the `build-docs` commmand in CI. But 
this should be a separate PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to