jml commented on issue #5757: [AIRFLOW-5100] Use safe_mode configuration setting by default URL: https://github.com/apache/airflow/pull/5757#issuecomment-519518556 Hi @BasPH, Thanks for responding so quickly. I think we might have different understandings as to what this PR is about. Specifically, it's not about exposing a new setting, it's about making an existing setting actually work. dag_discovery_safe_mode is already exposed to the end user as something they can configure: - https://airflow.apache.org/concepts.html?highlight=dag_discovery_safe_mode#dags - https://github.com/apache/airflow/blob/fc6967b2ada3985dc2c53b9ae90135fc0c1b27f4/airflow/config_templates/default_airflow.cfg#L201-L202 - https://apache-airflow.slack.com/archives/CCQ7EGB1P/p1564402338208800?thread_ts=1564402245.208700&cid=CCQ7EGB1P Pasting Slack messages for posterity: > @jml OK, we figured out what was going on. We *disabled* safe mode, and removed some comments that added "airflow" and "DAG" to our dag configs. Those DAGs then stopped running. We are confused, because we thought the whole point of disabling safe mode was so that they *would* run. > @ashb It _Should_ have. Unfortunately, the setting isn't respected by the scheduler. So, I'd rather not rename the setting in this PR, and instead focus on making the existing functionality work. Thanks! jml
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
