patgarz commented on code in PR #34051: URL: https://github.com/apache/airflow/pull/34051#discussion_r1316493843
########## airflow/auth/managers/fab/fab_auth_manager.py: ########## @@ -61,17 +61,27 @@ def get_cli_commands() -> list[CLICommand]: SYNC_PERM_COMMAND, # not in a command group ] + def get_user_display_name(self) -> str: + """Return the user's display name associated to the user in session.""" + user = self.get_user() + first_name = user.first_name or "" + last_name = user.last_name or "" + return f"{first_name} {last_name}".strip() Review Comment: Maybe `f"{first_name.strip()} {last_name.strip()}".strip()?` Ugly, but it works to accomplish both goals. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org