uranusjr commented on code in PR #34223:
URL: https://github.com/apache/airflow/pull/34223#discussion_r1324255943
##########
dev/prepare_release_issue.py:
##########
@@ -266,13 +266,10 @@ def generate_issue_content(
pull_requests: dict[int, PullRequestOrIssue] = {}
linked_issues: dict[int, list[Issue.Issue]] = defaultdict(lambda: [])
users: dict[int, set[str]] = defaultdict(lambda: set())
- count_prs = len(prs)
- if limit_pr_count:
- count_prs = limit_pr_count
+ count_prs = limit_pr_count if limit_pr_count else len(prs)
Review Comment:
```suggestion
count_prs = limit_pr_count or len(prs)
```
##########
dev/assign_cherry_picked_prs_with_milestone.py:
##########
@@ -276,9 +275,7 @@ def assign_prs(
console.print("\n[yellow]Implying --skip-assigned as summary report is
enabled[/]\n")
skip_assigned = True
milestone = repo.get_milestone(milestone_number)
- count_prs = len(prs)
- if limit_pr_count:
- count_prs = limit_pr_count
+ count_prs = limit_pr_count if limit_pr_count else len(changes)
Review Comment:
```suggestion
count_prs = limit_pr_count or len(changes)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
