jml commented on a change in pull request #5757: [AIRFLOW-5100] Use safe_mode configuration setting by default URL: https://github.com/apache/airflow/pull/5757#discussion_r312461672
########## File path: airflow/utils/dag_processing.py ########## @@ -288,18 +288,21 @@ def correct_maybe_zipped(fileloc): COMMENT_PATTERN = re.compile(r"\s*#.*") -def list_py_file_paths(directory, safe_mode=True, +def list_py_file_paths(directory, safe_mode=None, Review comment: Hi @kaxil, I'm happy to add tests, but as mentioned in the PR description, I need some pointers. Specifically: - which of the two testing strategies that I suggest would be most appropriate - if the second, I'm going to have to refactor things, and I don't want to do that if it's going to be in any way controversial - is there a context manager (or something similar) for temporarily setting configuration variables Thanks, jml ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
