jedcunningham commented on code in PR #34354: URL: https://github.com/apache/airflow/pull/34354#discussion_r1325103674
########## chart/newsfragments/31066.significant.rst: ########## @@ -2,10 +2,11 @@ Support naming customization on helm chart resources, some resources may be rena This is a new opt-in switch ``useStandardNaming``, for backwards compatibility, to leverage the standard naming convention, which allows full use of fullnameOverride and nameOverride in all resources. -Only the following resources will be renamed using default of ``useStandardNaming=false``: +The following resources will be renamed using default of ``useStandardNaming=false`` when upgrading to 1.11.0 or a higher version. Review Comment: ```suggestion The following resources will be renamed using default of ``useStandardNaming=false`` when upgrading to 1.11.0 or a higher version. ``` Let's add a newline here to the list is rendered properly 👍 ########## chart/newsfragments/31066.significant.rst: ########## @@ -2,10 +2,11 @@ Support naming customization on helm chart resources, some resources may be rena This is a new opt-in switch ``useStandardNaming``, for backwards compatibility, to leverage the standard naming convention, which allows full use of fullnameOverride and nameOverride in all resources. -Only the following resources will be renamed using default of ``useStandardNaming=false``: +The following resources will be renamed using default of ``useStandardNaming=false`` when upgrading to 1.11.0 or a higher version. Review Comment: ```suggestion The following resources will be renamed using default of ``useStandardNaming=false`` when upgrading to 1.11.0 or a higher version. ``` Let's add a newline here to the list is rendered properly 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
