mohannadbanayosi commented on a change in pull request #5768: [AIRFLOW-5153] Option to force delete non-empty BQ datasets URL: https://github.com/apache/airflow/pull/5768#discussion_r312488539
########## File path: airflow/contrib/hooks/bigquery_hook.py ########## @@ -1683,13 +1683,17 @@ def create_empty_dataset(self, dataset_id="", project_id="", 'BigQuery job failed. Error was: {}'.format(err.content) ) - def delete_dataset(self, project_id, dataset_id): + def delete_dataset(self, project_id, dataset_id, delete_contents): Review comment: Fixed and pushed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services