vandonr-amz commented on code in PR #34349:
URL: https://github.com/apache/airflow/pull/34349#discussion_r1326299906
##########
airflow/auth/managers/fab/fab_auth_manager.py:
##########
@@ -62,6 +70,24 @@ def get_cli_commands() -> list[CLICommand]:
SYNC_PERM_COMMAND, # not in a command group
]
+ def get_api_blueprint(self) -> None | Blueprint:
+ """Return a blueprint of the API endpoints proposed by this auth
manager."""
+ folder = Path(__file__).parents[0].resolve() # this is
airflow/auth/managers/fab/
+ with folder.joinpath("openapi", "v1.yaml").open() as f:
+ specification = safe_load(f)
+ api = FlaskApi(
+ specification=specification,
+ resolver=_LazyResolver(),
+ base_path="/security/v1",
Review Comment:
yeah having the `/auth/` prefix is good, it'll allow us to recommend other
providers to use it as well for a more consistent experience (like `/auth/aws`
for instance). I was not a big fan of leaking out the fact that the default
auth manager is fab, but if there is an agreement I'll happily comply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]