uranusjr commented on code in PR #34355:
URL: https://github.com/apache/airflow/pull/34355#discussion_r1326970695
##########
tests/api_connexion/endpoints/test_dag_warning_endpoint.py:
##########
@@ -35,14 +35,27 @@ def configured_app(minimal_app_for_api):
app, # type:ignore
username="test",
role_name="Test",
- permissions=[(permissions.ACTION_CAN_READ,
permissions.RESOURCE_DAG_WARNING)], # type: ignore
+ permissions=[
+ (permissions.ACTION_CAN_READ, permissions.RESOURCE_DAG_WARNING),
+ (permissions.ACTION_CAN_READ, permissions.RESOURCE_DAG),
+ ], # type: ignore
)
create_user(app, username="test_no_permissions",
role_name="TestNoPermissions") # type: ignore
+ create_user(
+ app, # type:ignore
+ username="test_with_dag2_read",
+ role_name="TestWithDag2Read",
+ permissions=[
+ (permissions.ACTION_CAN_READ, permissions.RESOURCE_DAG_WARNING),
+ (permissions.ACTION_CAN_READ, permissions.RESOURCE_DAG_PREFIX +
"dag2"),
Review Comment:
```suggestion
(permissions.ACTION_CAN_READ,
f"{permissions.RESOURCE_DAG_PREFIX}dag2"),
```
(This name-joining seems a bit weird though)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
