kaxil commented on a change in pull request #5743: [AIRFLOW-5088][AIP-24] 
Persisting serialized DAG in DB for webserver scalability
URL: https://github.com/apache/airflow/pull/5743#discussion_r312604975
 
 

 ##########
 File path: airflow/settings.py
 ##########
 @@ -310,3 +310,12 @@ def initialize():
 
 # Used by DAG context_managers
 CONTEXT_MANAGER_DAG = None
+
+# If dagcached is enabled, scheduler writes serialized DAGs to DB, and 
webserevr
+# reads DAGs from DB instead of importing from files.
+DAGCACHED_ENABLED = conf.getboolean('core', 'dagcached', fallback=True)
 
 Review comment:
   The default behavior should be still parsing from files until 2.0
   
   Changing it to the following
   
   ```suggestion
   DAGCACHED_ENABLED = conf.getboolean('core', 'dagcached', fallback=False)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to