nuclearpinguin commented on a change in pull request #5717: [AIRFLOW-5052]
Added the include_deleted params to salesforce make_query
URL: https://github.com/apache/airflow/pull/5717#discussion_r312638362
##########
File path: airflow/contrib/hooks/salesforce_hook.py
##########
@@ -73,19 +73,23 @@ def get_conn(self):
)
return self.conn
- def make_query(self, query):
+ def make_query(self, query, include_deleted=False, **query_params):
Review comment:
I thought rather about something like this:
```suggestion
def make_query(self, query, include_deleted=False, query_params=None):
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
