Lee-W commented on code in PR #34596:
URL: https://github.com/apache/airflow/pull/34596#discussion_r1335734579
##########
airflow/providers/amazon/aws/sensors/ecs.py:
##########
@@ -36,11 +36,12 @@
DEFAULT_CONN_ID: str = "aws_default"
-def _check_failed(current_state, target_state, failure_states):
+def _check_failed(current_state, target_state, failure_states, soft_fail):
if (current_state != target_state) and (current_state in failure_states):
- raise AirflowException(
- f"Terminal state reached. Current state: {current_state}, Expected
state: {target_state}"
- )
+ message = f"Terminal state reached. Current state: {current_state},
Expected state: {target_state}"
Review Comment:
```suggestion
# TODO: remove this if block when min_airflow_version is set to
higher than 2.7.1
message = f"Terminal state reached. Current state: {current_state},
Expected state: {target_state}"
```
##########
airflow/providers/amazon/aws/sensors/ecs.py:
##########
@@ -36,11 +36,12 @@
DEFAULT_CONN_ID: str = "aws_default"
-def _check_failed(current_state, target_state, failure_states):
+def _check_failed(current_state, target_state, failure_states, soft_fail):
Review Comment:
nitpick
```suggestion
def _check_failed(current_state, target_state, failure_states, soft_fail:
bool) -> None:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]