jedcunningham commented on code in PR #34349:
URL: https://github.com/apache/airflow/pull/34349#discussion_r1341837165


##########
airflow/auth/managers/base_auth_manager.py:
##########
@@ -50,6 +50,10 @@ def get_cli_commands() -> list[CLICommand]:
         """
         return []
 
+    def get_api_blueprint(self) -> None | Blueprint:

Review Comment:
   It might be possible to just build the plugin class conditionally and still 
reference it in the entry point, but I haven't actually tried it to see what 
that looks like.
   
   Just trying to see if it's realistic to use the plugin interface for the 
auth managers that do need that stuff, instead of reimplementing 
blueprint/menu/cli support for auth managers separately.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to