cjames23 opened a new pull request, #34705:
URL: https://github.com/apache/airflow/pull/34705

   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   This is a Draft PR to get feedback before putting out a lazy consensus to 
the dev list for a new provider for Open Search. This provider would be a 
pre-requisite for adding functionality to the Amazon provider for the AWS 
managed service for OpenSearch. This was discussed in a different 
[PR](https://github.com/apache/airflow/pull/34693) which will be blocked by 
this PR now. both PRs would be pre-work for completing 
https://github.com/apache/airflow/issues/33619 and adding Open Search log 
integration. 
   
   ### Open questions to more experienced contributors:
   
   1. For system test DAG to succeed would an OpenSearch domain need to be 
setup and if so what is the approach for standing up such infrastructure for 
integration tests?
   2. Any advice on mypy for some of the operator parameters? The goal is to 
allow users to either pass in the arguments directly or by passing in a class 
in the case of Search which works but in the case of adding a document the end 
user of the Operator needs to subclass the Document class. I am not sure what 
the best approach is for the typing for that parameter. 
   
   
   <!-- Please keep an empty line above the dashes. -->
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to