[
https://issues.apache.org/jira/browse/AIRFLOW-5162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904726#comment-16904726
]
ASF GitHub Bot commented on AIRFLOW-5162:
-----------------------------------------
steven-freed commented on pull request #5770: [AIRFLOW-5162] GCS Hook Upload
Method Improvement
URL: https://github.com/apache/airflow/pull/5770
**Jira**
- [x] My PR addresses the following Airflow Jira issues and references them
in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-5162
**Description**
- [x] Here are some details about my PR, including screenshots of any UI
changes:
- Allows developers to upload objects to a GCS bucket by either a local
file's file name or by a file's data (string or bytes). This may help prevent
issues related to crash consistency as well as help developers have a larger
variety of uploading options to GCS.
**Tests**
- [x] My PR adds the following unit tests OR does not need testing for this
extremely good reason:
- The changes made to the 'upload' method still allow for old functionality,
while supporting new functionality for Google GCS API methods.
**Commits**
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "How to write a good git commit message":
Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"
**Documentation**
- In case of new functionality, my PR adds documentation that describes how
to use it.
All the public functions and the classes in the PR contain docstrings that
explain what it does
If you implement backwards incompatible changes, please leave a note in the
Updating.md so we can assign it to a appropriate release
**Code Quality**
- [x] Passes flake8
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> GCS Uploads for local files and file data (string or bytes)
> -----------------------------------------------------------
>
> Key: AIRFLOW-5162
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5162
> Project: Apache Airflow
> Issue Type: Improvement
> Components: gcp
> Affects Versions: 1.10.4, 1.10.5
> Reporter: Steven Freed
> Priority: Minor
> Labels: beginner, features, pull-request-available
>
> Allows for gcs uploads to be done by specifying a local file name or by using
> the file's content. File content can be uploaded as a string or bytes. This
> gives developers more alternatives to uploading files where developers may
> have constraints on disk space and prefer to upload via file content in
> memory. This update also helps airflow update to Google's new
> 'upload_from_string' method for gcs.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
