ferruzzi commented on code in PR #34747:
URL: https://github.com/apache/airflow/pull/34747#discussion_r1346189969
##########
airflow/providers/amazon/aws/log/cloudwatch_task_handler.py:
##########
@@ -33,6 +33,24 @@
from airflow.models import TaskInstance
+def json_serialize_legacy(o):
+ """Json serializer replicating legacy watchtower behavior.
Review Comment:
```suggestion
"""
Json serializer replicating legacy watchtower behavior.
```
I'm surprised the style checks didn't get angry at this, perhaps that is one
of the checks that are not yet enabled, but first line of the docstring needs
to be on a newline.
##########
airflow/providers/amazon/aws/log/cloudwatch_task_handler.py:
##########
@@ -33,6 +33,24 @@
from airflow.models import TaskInstance
+def json_serialize_legacy(o):
+ """Json serializer replicating legacy watchtower behavior.
+
+ The legacy `watchtower@2.0.1` json serializer function that serialized
+ datetime objects as ISO format andall other non-JSON-serializable to
`null`.
Review Comment:
```suggestion
datetime objects as ISO format and all other non-JSON-serializable to
`null`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
