jens-scheffler-bosch commented on code in PR #33213:
URL: https://github.com/apache/airflow/pull/33213#discussion_r1346954190
##########
airflow/www/auth.py:
##########
@@ -35,16 +44,100 @@ def get_access_denied_message():
return conf.get("webserver", "access_denied_message")
-def has_access(permissions: Sequence[tuple[str, str]] | None = None) ->
Callable[[T], T]:
Review Comment:
+1, in our plugins we also use `airflow.www.auth.has_access` - if there is
any alternative we could migrate before but maybe there are a lot of other
plugins and users "in the wild" relying on this. So if the function at least is
kept as a proxy to the new implementation it would be good. I also do not know
any other alternative for the current main version how to check authentication
for plugins if not using this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
