vincbeck commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1347821224
##########
airflow/api_connexion/endpoints/dag_run_endpoint.py:
##########
@@ -76,12 +77,7 @@
RESOURCE_EVENT_PREFIX = "dag_run"
-@security.requires_access(
- [
- (permissions.ACTION_CAN_EDIT, permissions.RESOURCE_DAG),
- (permissions.ACTION_CAN_DELETE, permissions.RESOURCE_DAG_RUN),
- ],
-)
+@security.requires_access_dag("DELETE", DagAccessEntity.RUN)
Review Comment:
I guess it really depends on style but the reason I did that is I like
having a mapping 1:1 between the decorators `@security.requires_access_*` and
APIs in auth manager
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
