Lee-W commented on code in PR #34738: URL: https://github.com/apache/airflow/pull/34738#discussion_r1348316175
########## airflow/providers/microsoft/azure/CHANGELOG.rst: ########## @@ -27,6 +27,20 @@ Changelog --------- +8.0.0 +..... + +Breaking changes +~~~~~~~~~~~~~~~~ + +.. warning:: + In this version of the provider, we have removed network_profile param from AzureContainerInstancesOperator + +* Remove ``network_profile`` param from ``AzureContainerInstancesOperator`` +* Remove deprecated ``extra__azure__tenantId`` from azure_container_instance connection extras +* Remove deprecated ``extra__azure__subscriptionId`` from azure_container_instance connection extras Review Comment: Should we mention the named tuple `Volume` has been removed as well? ########## tests/providers/microsoft/azure/hooks/test_azure_container_instance.py: ########## @@ -52,7 +52,10 @@ def setup_test_cases(self, create_mock_connection): conn_type="azure_container_instances", login="login", password="key", - extra={"tenantId": "tenant_id", "subscriptionId": "subscription_id"}, + extra={ + "tenantId": "63e85d06-62e4-11ee-8c99-0242ac120002", Review Comment: Is it a valid id? or just some random one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org