Xiroo commented on code in PR #34715:
URL: https://github.com/apache/airflow/pull/34715#discussion_r1349613367
##########
airflow/sensors/external_task.py:
##########
@@ -341,6 +341,7 @@ def execute(self, context: Context) -> None:
states=self.allowed_states,
trigger_start_time=utcnow(),
poll_interval=self.poll_interval,
+ timeout=self.timeout,
Review Comment:
@utkarsharma2 Should I change to set default value to 60 sec?
However, I don't understand the meaning of "people 'using' the existing
default value of 60 sec kind of breaking change". It's just a default and fixed
value so no one could choose to use it.
Also, they even don't know there's default value of 60 if they didn't look
at the source code or failure log. (Even if they saw the failure log or source
code, they can't change it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
