vincbeck commented on PR #34786:
URL: https://github.com/apache/airflow/pull/34786#issuecomment-1755910306

   > What I did not fully get with the new API methods are, these are specific 
to the UI areas. If I add a `MyPlugin` then I would need to add a 
`has_access_my_plugin()` decorator, the ones existing are specific to the 
existing UI.
   
   Yes it can be an option. If you implement `MyPlugin`, then you can implement 
`has_access_my_plugin()` which checks whether the user has permissions to 
access the view provided by your plugin. In a following PR of #34317 (meaning: 
whenever #34317 is merged I'll be able to create another PR), I implement a 
mechanism to check custom permissions. By custom permissions I mean permissions 
defined outside of Airflow codebase (which is the case of plugins). As part of 
this PR I'll be able to implement also a `has_access_custom()` decorator which 
then can be used in such use case. Stay tuned :)
   
   > So besides public API would be good to add some hints into the plugin 
authoring docs - If you don't want to raise a PR I could if you help me in 
understanding.
   
   Yes, happy to work together on this one. Please feel free to create a PR and 
tag me on it and I'll be able to review it. Or you can ping me on Slack if you 
want


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to