potiuk commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1355902071
##########
airflow/api_connexion/endpoints/task_instance_endpoint.py:
##########
@@ -461,13 +436,8 @@ def get_task_instances_batch(session: Session =
NEW_SESSION) -> APIResponse:
)
-@security.requires_access(
- [
- (permissions.ACTION_CAN_EDIT, permissions.RESOURCE_DAG),
- (permissions.ACTION_CAN_READ, permissions.RESOURCE_DAG_RUN),
- (permissions.ACTION_CAN_EDIT, permissions.RESOURCE_TASK_INSTANCE),
- ],
-)
+@security.requires_access_dag("GET", DagAccessEntity.RUN)
Review Comment:
I think this change revealed a bug in the original permissions. Both RUN and
TASK_INSTANCE should be PUT (the code actually modifies DagRun state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
