eladkal commented on code in PR #34514:
URL: https://github.com/apache/airflow/pull/34514#discussion_r1356661637
##########
airflow/providers/google/cloud/operators/datafusion.py:
##########
@@ -34,16 +35,25 @@
from airflow.providers.google.cloud.operators.cloud_base import
GoogleCloudBaseOperator
from airflow.providers.google.cloud.triggers.datafusion import
DataFusionStartPipelineTrigger
from airflow.providers.google.cloud.utils.datafusion import
DataFusionPipelineType
+from airflow.providers.google.cloud.utils.helpers import resource_path_to_dict
if TYPE_CHECKING:
from airflow.utils.context import Context
class DataFusionPipelineLinkHelper:
- """Helper class for Pipeline links."""
+ """
+ Helper class for Pipeline links.
+
+ .. warning::
+ This class is deprecated. Consider using ``resource_path_to_dict()``
instead.
+ """
@staticmethod
def get_project_id(instance):
+ warnings.warn(
+ "DataFusionPipelineLinkHelper is deprecated. Consider using
resource_path_to_dict() instead."
Review Comment:
You need to raise `AirflowProviderDeprecationWarning`
also consider suggests there is a choice... it's not the case. User must
migrate to the alternative as the class will be removed in future release
##########
airflow/providers/google/cloud/operators/datafusion.py:
##########
@@ -34,16 +35,25 @@
from airflow.providers.google.cloud.operators.cloud_base import
GoogleCloudBaseOperator
from airflow.providers.google.cloud.triggers.datafusion import
DataFusionStartPipelineTrigger
from airflow.providers.google.cloud.utils.datafusion import
DataFusionPipelineType
+from airflow.providers.google.cloud.utils.helpers import resource_path_to_dict
if TYPE_CHECKING:
from airflow.utils.context import Context
class DataFusionPipelineLinkHelper:
- """Helper class for Pipeline links."""
+ """
+ Helper class for Pipeline links.
+
+ .. warning::
+ This class is deprecated. Consider using ``resource_path_to_dict()``
instead.
+ """
@staticmethod
def get_project_id(instance):
+ warnings.warn(
+ "DataFusionPipelineLinkHelper is deprecated. Consider using
resource_path_to_dict() instead."
Review Comment:
You need to raise `AirflowProviderDeprecationWarning`
also the word consider suggests there is a choice... it's not the case. User
must migrate to the alternative as the class will be removed in future release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
