Taragolis commented on code in PR #34896:
URL: https://github.com/apache/airflow/pull/34896#discussion_r1357314685


##########
airflow/providers/microsoft/azure/operators/synapse.py:
##########
@@ -49,6 +49,7 @@ class AzureSynapseRunSparkBatchOperator(BaseOperator):
     template_fields: Sequence[str] = (
         "azure_synapse_conn_id",
         "spark_pool",
+        "payload"

Review Comment:
   Just wondering how it supposed to be work? According to the `payload` 
annotation it is expected to get 
`azure.synapse.spark.models.SparkBatchJobOptions` object
   
   
https://github.com/apache/airflow/blob/9d8c77e447f5515b9a6aa85fa72511a86a128c28/airflow/providers/microsoft/azure/operators/synapse.py#L63
   
   For allow render templates for custom types it is required to have 
templated_field class method, see: [Jinja 
Templating](https://airflow.apache.org/docs/apache-airflow/stable/core-concepts/operators.html#jinja-templating)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to