eladkal commented on code in PR #34386:
URL: https://github.com/apache/airflow/pull/34386#discussion_r1358077855
##########
airflow/security/kerberos.py:
##########
@@ -59,10 +63,7 @@ def renew_from_kt(principal: str | None, keytab: str,
exit_on_fail: bool = True)
# minutes to give ourselves a large renewal buffer.
renewal_lifetime = f"{conf.getint('kerberos', 'reinit_frequency')}m"
- cmd_principal = principal or conf.get_mandatory_value("kerberos",
"principal").replace(
- "_HOST", get_hostname()
- )
-
+ cmd_principal = get_kerberos_principle(principal)
Review Comment:
This PR changes code in both core and in providers and it has separated
release cycle.
So if we can extract the `airflow/security/kerberos.py` to a separated PR we
will get it merge then rebase this PR
This will make release manager life much easier
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
