Taragolis commented on code in PR #34914:
URL: https://github.com/apache/airflow/pull/34914#discussion_r1358185661


##########
airflow/models/dag.py:
##########
@@ -475,6 +475,8 @@ def __init__(
         self.user_defined_filters = user_defined_filters
         if default_args and not isinstance(default_args, dict):
             raise TypeError("default_args must be a dict")
+        if "retries" in default_args.keys() and 
type(default_args.get("retries"))!= int:
+            raise TypeError("retries must be a int")

Review Comment:
   If we want to check retries then we need to check retires in base operator 
or BaseOperatorMeta, and not in default_args



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to