kimminw00 commented on PR #34735:
URL: https://github.com/apache/airflow/pull/34735#issuecomment-1763290879

   Prometheus and alertmanager are different apps. So they have different 
<code>app.kubernetes.io/name</code>
   
   
https://github.com/prometheus-community/helm-charts/blob/f57ff6651817b23c21daa7d5cd087649add5836e/charts/kube-prometheus-stack/templates/alertmanager/serviceaccount.yaml#L9
   
   
https://github.com/prometheus-community/helm-charts/blob/f57ff6651817b23c21daa7d5cd087649add5836e/charts/kube-prometheus-stack/templates/prometheus/serviceaccount.yaml#L9C1-L9C85
   
   Ariflow, pgbouncer, redis, and statsd(may be there is more apps!) need to 
have different <code>app.kubernetes.io/name</code> in the same way.
   (But I'm not sure that webserver, scheduler, dag processor, triggerer, etc., 
are different apps as they run in the same container image)
   
   And you have to tests if app name is not longer than 63 chars.
   
https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#dns-label-names


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to