vincbeck commented on PR #34942: URL: https://github.com/apache/airflow/pull/34942#issuecomment-1764625106
> Oh yeah. Two days ago I noticed the same problems while reviewing #34317 > > See my comments here: [#34317 (comment)](https://github.com/apache/airflow/pull/34317#discussion_r1355894015) and [#34317 (comment)](https://github.com/apache/airflow/pull/34317#discussion_r1355907009) (and few others). > > This code will go away soon (cc: @vincbeck ). But maybe it's worth to reconcile the two changes and see if all the read->edit changes are same in both (@hussein-awala and @vincbeck ?). It looks they are all the same. > > And maybe it makes sense to merge this change first and #34317 afterwards to clearly separate fix from the Auth manager refactor? > > And no - I think it should not be treated as a breaking change, the previous settings made really no sense (having access to task_instance while not having access to dag_run was wrong because by changing task_instance state you can impact state of the dag_run), however we should have a significant note about it. Yep I agree, let's merge this one first and I'll make the change in my PR as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
