bolkedebruin commented on PR #34729:
URL: https://github.com/apache/airflow/pull/34729#issuecomment-1766388128
@uranusjr @jens-scheffler-bosch @ashb PTL. I have changed the code now so
that ObjectStoragePath can be used as a PathLike object with some extensions.
See also the updated initial description. Mounts are renamed to `aliases' and
not (really) visible nor usable to the user.
- Some things I like about the new notation, somethings I don't (like using
`find`).
- I'm not sure where to put `copy` and `move` yet. In `utils` as it is now
or in the class.
- What to do with orphaned paths, i.e. without a store or a protocol like
ObjectStoragePath("/my/path"). On its own it might refer to a local file path,
which is a pretty natural thing, but concatened with
ObjectStoragePath("s3://warehouse") it becomes a key. Note we can do
`ObjectStoragePath("s3://warehouse") / "key"`, because it is clear what the
intent is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
