uranusjr commented on code in PR #34729: URL: https://github.com/apache/airflow/pull/34729#discussion_r1363124027
########## airflow/io/store/path.py: ########## @@ -0,0 +1,666 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +import contextlib +import os +import typing +from io import UnsupportedOperation +from stat import S_ISLNK + +from fsspec.utils import stringify_path + +from airflow.io.store import ObjectStore, attach + + +def _rewrite_info(info: dict, store: ObjectStore) -> dict: + info["name"] = ObjectStoragePath(info["name"], store=store) + return info + + +class ObjectStoragePath(os.PathLike): Review Comment: I wonder if this should have a… cooler(?) name such as `AirflowStorePath`. `ObjectStoragePath` seems a bit abstract. It is somewhat important to name this kind of thing catchy so it is more distinguishable in conversation. (As a negative example, “task” is not very well named.) ########## airflow/io/store/path.py: ########## @@ -0,0 +1,666 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +import contextlib +import os +import typing +from io import UnsupportedOperation +from stat import S_ISLNK + +from fsspec.utils import stringify_path + +from airflow.io.store import ObjectStore, attach + + +def _rewrite_info(info: dict, store: ObjectStore) -> dict: + info["name"] = ObjectStoragePath(info["name"], store=store) + return info + + +class ObjectStoragePath(os.PathLike): Review Comment: I wonder if this should have a… cooler(?) name such as `AirflowStorePath`. `ObjectStoragePath` seems a bit abstract. It is somewhat important to name this kind of thing catchy so it is more distinguishable in conversation. (As a negative example, “task” is not very well named.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org