uranusjr commented on code in PR #34379:
URL: https://github.com/apache/airflow/pull/34379#discussion_r1363453798
##########
airflow/utils/log/file_task_handler.py:
##########
@@ -476,16 +476,17 @@ def _init_file(self, ti):
# if this is true, we're invoked via set_context in the context of
# setting up individual trigger logging. return trigger log path.
full_path = self.add_triggerer_suffix(full_path=full_path,
job_id=ti.triggerer_job.id)
- self._prepare_log_folder(Path(full_path).parent)
+ path = Path(full_path)
+ self._prepare_log_folder(os.fspath(path.parent))
Review Comment:
Doesn’t `_prepare_log_folder` take a Path instead? The `os.fspath` call
shouldn’t be there.
##########
airflow/utils/log/file_task_handler.py:
##########
@@ -476,16 +476,17 @@ def _init_file(self, ti):
# if this is true, we're invoked via set_context in the context of
# setting up individual trigger logging. return trigger log path.
full_path = self.add_triggerer_suffix(full_path=full_path,
job_id=ti.triggerer_job.id)
- self._prepare_log_folder(Path(full_path).parent)
+ path = Path(full_path)
+ self._prepare_log_folder(os.fspath(path.parent))
Review Comment:
Doesn’t `_prepare_log_folder` take a Path instead? The `os.fspath` call
shouldn’t be there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
