potiuk commented on code in PR #34729: URL: https://github.com/apache/airflow/pull/34729#discussion_r1365792355
########## docs/apache-airflow/extra-packages-ref.rst: ########## @@ -68,6 +68,8 @@ python dependencies for the provided package. +---------------------+-----------------------------------------------------+----------------------------------------------------------------------------+ | sentry | ``pip install 'apache-airflow[sentry]'`` | Sentry service for application logging and monitoring | +---------------------+-----------------------------------------------------+----------------------------------------------------------------------------+ +| s3fs | ``pip install 'apache-airflow[s3fs]'`` | Support for S3 as Airflow FS | Review Comment: Yes. Was just looking at it catching up with the discussion - we should have similar `s3fs` additional-extra in amazon provider as we have with aiobotocore. Then the imports from s3fs (since it will be optional feature of amazon provider) should throw AirflowOptionalProviderFeatureException if there is an import error. Then we should remove the "global" s3fs extra for airflow - it's place is here and enabling it will require installing `apache-airflow-providers-amazon[s3fs]` or manually installing the dependency. Note - this is special "Amazon" case. If there are no other conflicting dependencies in gcs/amazon, we can make those libraries "required" dependencies - the main reason why we are doing it as optional dependency is the way how aiobotocore pins to specific versions of boto and we do not want our users to be limited to the boto2 pinned in the latest relesed version of the aiobotocore. This is special case handling this unusual behaviour. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
