Joffreybvn commented on code in PR #34964:
URL: https://github.com/apache/airflow/pull/34964#discussion_r1367026145
##########
airflow/models/baseoperator.py:
##########
@@ -1219,14 +1226,10 @@ def __deepcopy__(self, memo):
return result
def __getstate__(self):
- state = dict(self.__dict__)
- del state["_log"]
-
- return state
+ return dict(self.__dict__)
Review Comment:
I admit the getstate/setstate part was not very clear to me.
I removed it because I assumed that a new `_log` object would be setup by
the LoggingMixin anyway. But we have to keep it, is it because some Operators
may customize their logging name ?
(I did not found such Operator, but I'd be happy to add a test case if
someone point me out the purpose of this code).
In all cases, I'll put back the deletion and rebuilt :blush:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
