potiuk commented on code in PR #35061: URL: https://github.com/apache/airflow/pull/35061#discussion_r1367396267
########## scripts/ci/docker-compose/devcontainer.env: ########## @@ -18,6 +18,7 @@ HOME= AIRFLOW_CI_IMAGE="ghcr.io/apache/airflow/main/ci/python3.8:latest" ANSWER= AIRFLOW_ENABLE_AIP_44="true" +AIRFLOW_ENV="development" Review Comment: If you want to set it always: 1) Dockerfile.ci (requires rebuilding the image) or 2) entrypoint_ci.sh at the beginning But I do not think you want to hard-code it and alwaays have it in in breeze. I think breeze `start-airflow` should be "as standard as possible" and any dev mode should be set explicitly. I think it would be better to only set it in case you run `start-airflow` with `--dev-mode` (flag we already have). So maybe rather than inventing a new variable you should use the existing `DEV_MODE` variable for that. We already have it set to `true` when you pass `--dev-mode` either to `shell` command or `start-airflow` You can search and see where DEV_MODE is set alredy: * scripts/ci/docker-compose/_docker.env * scripts/ci/docker-compose/base.yml And the value ("true/false") is set in src/airflow_breeze/utils/docker_command_utils.py in the MAP where you map "dev_mode" attribute into DEV_MODE env variable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org