potiuk commented on PR #35086: URL: https://github.com/apache/airflow/pull/35086#issuecomment-1773778101
All looks good I have just a few general comments (and some improvement proposals / test results will come as inline comments). 1. We will need this "all-airflow" images only once to generate all historical versions of providers. But we might find some errors/problems/need to regenerate those so we should keep it. I already have the cache built on my local machine too, so I might push them to our ghcr.io repo and pull rather than rebuild them. I can make some comments on how this can be done easily @pierrejeambrun (might be useful to learn how caching works) - or I can do it as a follow-up PR as you wish, let me know:). 2. Later when we turn it into "generate requirements for the last wave of providers only" the default should be to use the "latest release image" for those tests only - but we should add such capability as separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
