amoghrajesh commented on code in PR #35102:
URL: https://github.com/apache/airflow/pull/35102#discussion_r1367747019
##########
dev/breeze/src/airflow_breeze/params/doc_build_params.py:
##########
@@ -20,20 +20,30 @@
from dataclasses import dataclass
from airflow_breeze.branch_defaults import AIRFLOW_BRANCH
+from airflow_breeze.global_constants import ALL_SPECIAL_DOC_KEYS
providers_prefix = "apache-airflow-providers-"
-def get_provider_name_from_short_hand(short_form_providers: tuple[str]):
+def get_provider_name_from_short_hand(short_form_packages: tuple[str, ...]) ->
tuple[str, ...]:
return tuple(
- providers_prefix + short_form_provider.replace(".", "-")
- for short_form_provider in short_form_providers
+ providers_prefix + short_form_packaage.replace(".", "-")
+ for short_form_packaage in short_form_packages
+ if short_form_packaage not in ALL_SPECIAL_DOC_KEYS
+ )
+
+
+def get_special_doc_keys_from_shor_hand(short_form_packages: tuple[str, ...])
-> tuple[str, ...]:
Review Comment:
Same comment here
##########
dev/breeze/src/airflow_breeze/params/doc_build_params.py:
##########
@@ -20,20 +20,30 @@
from dataclasses import dataclass
from airflow_breeze.branch_defaults import AIRFLOW_BRANCH
+from airflow_breeze.global_constants import ALL_SPECIAL_DOC_KEYS
providers_prefix = "apache-airflow-providers-"
-def get_provider_name_from_short_hand(short_form_providers: tuple[str]):
+def get_provider_name_from_short_hand(short_form_packages: tuple[str, ...]) ->
tuple[str, ...]:
Review Comment:
Should we instead make the type fixed instead of using elipses?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
