potiuk commented on code in PR #34964:
URL: https://github.com/apache/airflow/pull/34964#discussion_r1367946473
##########
airflow/models/baseoperator.py:
##########
@@ -651,6 +653,10 @@ class derived from this one results in the creation of a
task object,
that is visible in Task Instance details View in the Webserver
:param doc_yaml: Add documentation (in YAML format) or notes to your Task
objects
that is visible in Task Instance details View in the Webserver
+ :param logger_name: Name of the logger used by the Operator to emit logs.
+ Default is "airflow.task.operators". If set to `None`, the logger name
will fall back
+ to `{class.__module__}.{class.__name__}` (e.g. SimpleHttpOperator will
have
Review Comment:
Similar NIT -> this docstring is now not entirely accurate (lack of
"airflow.task.operarors" prefix.
##########
airflow/hooks/base.py:
##########
@@ -41,8 +41,17 @@ class BaseHook(LoggingMixin):
object that can handle the connection and interaction to specific
instances of these systems, and expose consistent methods to interact
with them.
+
+ :param logger_name: Name of the logger used by the Hook to emit logs.
+ If set to `None` (default), the logger name will fall back to
`{class.__module__}.{class.__name__}`
+ (e.g. DbApiHook will have
*airflow.providers.common.sql.hooks.sql.DbApiHook* as logger).
Review Comment:
One NIT -> this docstring is now not entirely accurate (lack of
"airflow.task.hooks" prefix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
