uranusjr commented on code in PR #35017:
URL: https://github.com/apache/airflow/pull/35017#discussion_r1368237626
##########
tests/template/test_templater.py:
##########
@@ -60,3 +60,23 @@ def test_render_template(self):
templater.template_ext = [".txt"]
rendered_content = templater.render_template(templater.message,
context)
assert rendered_content == "Hello world"
+
+ def test_not_render_literal_value(self):
+ templater = Templater()
+ templater.template_ext = []
+ context = Context({"name": "world"}) # type: ignore
Review Comment:
Why not just use a key that’s defined here?
##########
tests/template/test_templater.py:
##########
@@ -60,3 +60,23 @@ def test_render_template(self):
templater.template_ext = [".txt"]
rendered_content = templater.render_template(templater.message,
context)
assert rendered_content == "Hello world"
+
+ def test_not_render_literal_value(self):
+ templater = Templater()
+ templater.template_ext = []
+ context = Context({"name": "world"}) # type: ignore
Review Comment:
Why not just use a key that’s defined here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
