hakuno opened a new pull request, #35130:
URL: https://github.com/apache/airflow/pull/35130
It improves (or fixes) the `workers.safeToEvict` usage.
Kubernetes administrators/users agree that
`cluster-autoscaler.kubernetes.io/safe-to-evict` can be managed to avoid the
Autoscaler to kill the worker pod when scaling nodes down.
> When this annotation is set to "true", the cluster autoscaler is allowed
to evict a Pod even if other rules would normally prevent that. The cluster
autoscaler never evicts Pods that have this annotation explicitly set to
"false"; you could set that on an important Pod that you want to keep running.
If this annotation is not set then the cluster autoscaler follows its Pod-level
behavior.
So, if I set `workers.safeToEvict` to `false`, it gets nothing. The
Autoscaler will kill that still. Because the Helm chart has no effect on
handling that. See:
```
{{- if .Values.workers.safeToEvict }}
cluster-autoscaler.kubernetes.io/safe-to-evict: "true"
{{- end }}
```
It's like a useless piece of statement.
What about if I need to set that to false? I couldn't. Anybody is unable to.
A probaly **workaround** would set up `workers.podAnnotations` with map of
_annotations_ and `workers.safeToEvict` falsely together.
Please, check it out carefully. Thanks in advance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
