potiuk commented on code in PR #35146:
URL: https://github.com/apache/airflow/pull/35146#discussion_r1370512003
##########
airflow/cli/cli_config.py:
##########
@@ -561,6 +561,7 @@ def string_lower_type(val):
# kerberos
ARG_PRINCIPAL = Arg(("principal",), help="kerberos principal", nargs="?")
ARG_KEYTAB = Arg(("-k", "--keytab"), help="keytab", nargs="?",
default=conf.get("kerberos", "keytab"))
+ARG_KERBEROS_MODE = Arg(("-m", "--mode"), help="mode to run airflow kerberos",
nargs="?", default="daemon")
Review Comment:
Looking at the screenshots. Since we also have `--daemon` mode using deamon
here as well is misleding - so likely we should come with a different name.
Mabye simply we should call it "standard" mode ?
##########
airflow/cli/cli_config.py:
##########
@@ -561,6 +561,7 @@ def string_lower_type(val):
# kerberos
ARG_PRINCIPAL = Arg(("principal",), help="kerberos principal", nargs="?")
ARG_KEYTAB = Arg(("-k", "--keytab"), help="keytab", nargs="?",
default=conf.get("kerberos", "keytab"))
+ARG_KERBEROS_MODE = Arg(("-m", "--mode"), help="mode to run airflow kerberos",
nargs="?", default="daemon")
Review Comment:
Looking at the screenshots. Since we also have `--daemon` mode using deamon
here as well is misleding - so likely we should come with a different name.
Maybe simply we should call it "standard" mode ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
