Joffreybvn commented on code in PR #34964: URL: https://github.com/apache/airflow/pull/34964#discussion_r1370789066
########## tests/providers/docker/hooks/test_docker.py: ########## @@ -36,7 +36,7 @@ TEST_CONN = {"host": "some.docker.registry.com", "login": "some_user", "password": "some_p4$$w0rd"} MOCK_CONNECTION_NOT_EXIST_MSG = "Testing connection not exists" MOCK_CONNECTION_NOT_EXISTS_EX = AirflowNotFoundException(MOCK_CONNECTION_NOT_EXIST_MSG) -HOOK_LOGGER_NAME = "airflow.providers.docker.hooks.docker.DockerHook" +HOOK_LOGGER_NAME = "airflow.task.hooks.airflow.providers.docker.hooks.docker.DockerHook" Review Comment: By full test, you mean adding one test for each hooks and operators, right ? I considered it, especially because any folder / file renaming could cause a breaking change for users with advanced logging config. I haven't done it because it takes time. But I can certainly add those tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org