PashkPashk commented on PR #35096: URL: https://github.com/apache/airflow/pull/35096#issuecomment-1778140569
> This looks good. Thanks for the contribution. > > I was thinging (but have no strong opinion) as whether it makes sense to extract this to a utility, but keeping it here might be acceptable. > > Can you please add a unit test for the new code which validates a positive and negative case as well? Could you, please, advise me where I should add this test? https://github.com/apache/airflow/blob/ef497bc3412273c3a45f43f40e69c9520c7cc74c/tests/api_connexion/schemas/test_dag_run_schema.py#L49 This module? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
