eladkal commented on code in PR #34926:
URL: https://github.com/apache/airflow/pull/34926#discussion_r1372113523


##########
airflow/providers/databricks/CHANGELOG.rst:
##########
@@ -61,6 +61,13 @@ Misc
 4.5.0
 .....
 
+Breaking changes
+~~~~~~~~~~~~~~~~
+
+The ``offset`` parameter has been deprecated from ``list_jobs`` in favor of 
faster pagination with ``page_token`` similarly to `Databricks API 
<https://docs.databricks.com/api/workspace/jobs/list>`_.
+
+* ``Remove offset-based pagination from list_jobs function in DatabricksHook 
(#34926)``
+

Review Comment:
   Please remove this line.
   This will be created automatically by release manager



##########
airflow/providers/databricks/CHANGELOG.rst:
##########
@@ -61,6 +61,13 @@ Misc
 4.5.0
 .....
 
+Breaking changes
+~~~~~~~~~~~~~~~~
+
+The ``offset`` parameter has been deprecated from ``list_jobs`` in favor of 
faster pagination with ``page_token`` similarly to `Databricks API 
<https://docs.databricks.com/api/workspace/jobs/list>`_.

Review Comment:
   It's not in the right place it should be at the top of the log before the
   ```
   Changelog
   ---------
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to