hussein-awala commented on code in PR #35160:
URL: https://github.com/apache/airflow/pull/35160#discussion_r1375469882
##########
tests/jobs/test_triggerer_job.py:
##########
@@ -110,6 +112,9 @@ def create_trigger_in_db(session, trigger, operator=None):
return dag_model, run, trigger_orm, task_instance
+# Quarantined because this test is failing the first time it is run. The
second time succeeds
+# Seems to be connected with SOME race condition and needs to be investigated
+@pytest.mark.quarantined
Review Comment:
I checked the failure, and found that it's because we received an empty
stdout when we reset the db (I still do not know why), so I wonder if we can
just remove:
```
assert "test_dag/test_run/sensitive_arg_task/-1/1 (ID 1) starting" in stdout
```
and keep
```
assert "some_password" not in stdout
```
instead of quarantine it 🤔
The goal of this test is to ensure that the sensitive data are not logged,
and this change should be okay, wdyt?
##########
tests/jobs/test_triggerer_job.py:
##########
@@ -110,6 +112,9 @@ def create_trigger_in_db(session, trigger, operator=None):
return dag_model, run, trigger_orm, task_instance
+# Quarantined because this test is failing the first time it is run. The
second time succeeds
+# Seems to be connected with SOME race condition and needs to be investigated
+@pytest.mark.quarantined
Review Comment:
I checked the failure, and found that it's because we received an empty
stdout when we reset the db (I still do not know why), so I wonder if we can
just remove:
```
assert "test_dag/test_run/sensitive_arg_task/-1/1 (ID 1) starting" in stdout
```
and keep
```
assert "some_password" not in stdout
```
instead of quarantine it 🤔
The goal of this test is to ensure that the sensitive data are not logged,
and this change should be okay, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
